Re: [PATCH v2 2/6] dt: bindings: lp8860: Update DT label binding

[Dan Murphy]

Rob

On 12/07/2017 04:45 PM, Rob Herring wrote:
> On Tue, Dec 05, 2017 at 02:43:23PM -0600, Dan Murphy wrote:
>> Update the lp8860 label binding to the LED
>> standard as documented in
>>
>> Documentation/devicetree/bindings/leds/common.txt
>>
>> Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
>> ---
>>
>> v2 - Added reg to child node and made it required
>>
>>  Documentation/devicetree/bindings/leds/leds-lp8860.txt | 12 ++++++++++--
>>  1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> index 1b2fab05ec6a..22b594d95162 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> @@ -9,7 +9,6 @@ Required properties:
>>  	- compatible :
>>  		"ti,lp8860"
>>  	- reg : I2C slave address
>> -	- label : Used for naming LEDs
>>  	- #address-cells : 1
>>  	- #size-cells : 0
>>  
>> @@ -17,6 +16,12 @@ Optional properties:
>>  	- enable-gpios : gpio pin to enable/disable the device.
>>  	- supply : "vled" - LED supply
>>  
>> +Required child properties:
>> +	- reg : 0
>> +
>> +Optional child properties:
>> +	- label : see Documentation/devicetree/bindings/leds/common.txt
>> +
>>  Example:
>>  
>>  	lp8860@2d {
>> @@ -24,9 +29,12 @@ Example:
>>  		#address-cells: 1
>>  		#size-cells: 0
>>  		reg = <0x2d>;
>> -		label = "display_cluster";
>>  		enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>>  		vled-supply = <&vbatt>;
>> +		display_cluster: display_cluster@0 {
> 
> led@0 {
> 
> Do you really need a (dts) label here?

We will when I add LED string support.

> 
>> +			reg=<0>;
> 
> spaces around the '='.

Ack

> 
>> +			label = "display_cluster";
>> +		};
>>  	}
>>  
>>  For more product information please see the link below:
>> -- 
>> 2.15.0.124.g7668cbc60
>>


-- 
------------------
Dan Murphy