Re: [PATCH v3] mm, thp: introduce generic transparent huge page allocation interfaces

[Du, Changbin]

Hi Andrew,
On Thu, Dec 07, 2017 at 03:45:19PM -0800, Andrew Morton wrote:
> On Thu,  7 Dec 2017 18:54:19 +0800 changbin.du@xxxxxxxxx wrote:
> 
> > From: Changbin Du <changbin.du@xxxxxxxxx>
[snip]
 > -static inline void prep_transhuge_page(struct page *page) {}
> > +#define alloc_transhuge_page_vma(gfp_mask, vma, addr) NULL
> > +#define alloc_transhuge_page_nodemask(gfp_mask, preferred_nid, nmask) NULL
> > +#define alloc_transhuge_page_node(nid, gfp_maskg) NULL
> > +#define alloc_transhuge_page(gfp_mask) NULL
> 
> Ugly.  And such things can cause unused-variable warnings in calling
> code.  Whereas
> 
> static inline struct page *alloc_transhuge_page_vma(gfp_t gfp_mask,
> 			struct vm_area_struct *vma, unsigned long addr)
> {
> 	return NULL;
> }
> 
> will avoid such warnings.
>
Thanks for pointing out, I will update it.
   
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>

-- 
Thanks,
Changbin Du