Re: [PATCH v2 08/35] nds32: Process management

From: Greentime Hu
Date: Fri Dec 08 2017 - 00:28:45 EST


2017-12-08 0:45 GMT+08:00 Al Viro <viro@xxxxxxxxxxxxxxxxxx>:
> On Mon, Nov 27, 2017 at 08:27:55PM +0800, Greentime Hu wrote:
>
>> +#define start_thread(regs,pc,stack) \
>> +({ \
>> + set_fs(USER_DS); \
>
> Not the job of start_thread() - its users (->load_binary() methods of
> assorted binfmt) must (and do) call flush_old_exec() first. And
> that will switch to USER_DS just fine.

Thanks. I will remove this setting in the next version patch.