Re: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement

From: Michal Hocko
Date: Fri Dec 08 2017 - 03:48:04 EST


On Fri 08-12-17 16:38:46, kemi wrote:
>
>
> On 2017å11æ30æ 17:45, Michal Hocko wrote:
> > On Thu 30-11-17 17:32:08, kemi wrote:
>
> > Do not get me wrong. If we want to make per-node stats more optimal,
> > then by all means let's do that. But having 3 sets of counters is just
> > way to much.
> >
>
> Hi, Michal
> Apologize to respond later in this email thread.
>
> After thinking about how to optimize our per-node stats more gracefully,
> we may add u64 vm_numa_stat_diff[] in struct per_cpu_nodestat, thus,
> we can keep everything in per cpu counter and sum them up when read /proc
> or /sys for numa stats.
> What's your idea for that? thanks

I would like to see a strong argument why we cannot make it a _standard_
node counter.
--
Michal Hocko
SUSE Labs