Re: [PATCH v2 0/5] perf-probe: Improve probing on versioned symbols

From: Thomas-Mich Richter
Date: Fri Dec 08 2017 - 06:56:21 EST


On 12/07/2017 08:19 AM, Masami Hiramatsu wrote:
> Hi,
>
> Here is the 2nd version of the series for probing on
> versioned symbols in libraries. This includes 5 patches
> to fix the issues discussed on perf-users ML
> (https://www.spinics.net/lists/linux-perf-users/msg04637.html)
>
> The first version is here; https://lkml.org/lkml/2017/12/5/1124
>
> Here is the updates;
>
> [3/5] Add a description in Documentation/perf-probe.txt
> [5/5] Add a description and examples in Documentation/perf-probe.txt
>
> Thank you,
> ---
>
> Masami Hiramatsu (5):
> perf-probe: Add warning message if there is unexpected event name
> perf-probe: Cut off the version suffix from event name
> perf-probe: Add __return suffix for return events
> perf-probe: Find versioned symbols from map
> perf-probe: Support escaped character in parser
>
>
> tools/perf/Documentation/perf-probe.txt | 18 ++++++
> tools/perf/arch/powerpc/util/sym-handling.c | 8 +++
> tools/perf/util/probe-event.c | 81 +++++++++++++++++++--------
> tools/perf/util/string.c | 46 +++++++++++++++
> tools/perf/util/string2.h | 2 +
> tools/perf/util/symbol.c | 5 ++
> tools/perf/util/symbol.h | 1
> 7 files changed, 137 insertions(+), 24 deletions(-)
>
> --
> Masami Hiramatsu (Linaro Ltd.) <mhiramat@xxxxxxxxxx>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-perf-users" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

If you fix the findings for patch 4 and 5 you have my

Reviewed-by: Thomas Richter <tmricht@xxxxxxxxxxxxxxxxxx>
--
Thomas Richter, Dept 3303, IBM LTC Boeblingen Germany
--
Vorsitzende des Aufsichtsrats: Martina Koederitz
GeschÃftsfÃhrung: Dirk Wittkopp
Sitz der Gesellschaft: BÃblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294