Re: [PATCH 2/2] tools/lib/lockdep: add empty declaration for early_param

[alexander . levin]

On Fri, Dec 08, 2017 at 07:20:10AM +0100, Ingo Molnar wrote:
>
>* Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
>>
>> * alexander.levin@xxxxxxxxxxx <alexander.levin@xxxxxxxxxxx> wrote:
>>
>> > Fixes a compilation error:
>> >
>> >   CC       lockdep.o
>> > In file included from lockdep.c:28:0:
>> > ../../../kernel/locking/lockdep.c:89:13: error: expected declaration specifiers or â...â before string constant
>> >  early_param("crossrelease_fullstack", allow_crossrelease_fullstack);
>> >              ^~~~~~~~~~~~~~~~~~~~~~~~
>> > ../../../kernel/locking/lockdep.c:89:39: error: expected declaration specifiers or â...â before âallow_crossrelease_fullstackâ
>> >  early_param("crossrelease_fullstack", allow_crossrelease_fullstack);
>> >                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Ugh, this changelog was in DOS format (had extra \r's) - how did that happen?
>
>Hm, so it's because the second patch email was sent as as a base64 encoded email:
>
>  Content-Transfer-Encoding: base64
>
>totally not recommended and git-send-email will not do that - what happened?

I'm not sure, this was sent using git-send-email...

>>
>> Fixed it up.
>
>Actually, could you please resend the whole series, with a fix for the other
>warning I reported added, with the changelogs fixed, and not MIME encoded?

Sure!

-- 

Thanks,
Sasha