Re: [PATCH v1 1/2] eeprom: at24: convert magic numbers to structs.

[Sven Van Asbroeck]

Bartosz wrote:
> Just make it accept two parameters: the string and the data object
> name. For example:
>
> AT24_OF_DEVICE_ID("atmel,24c01", 24c01);
>

I don't want to do too much bikeshedding,
but one last comment.

Is it a good idea to have duplicated information?
Do you think the risk of a typo mismatch is acceptable? E.g.
AT24_OF_DEVICE_ID("atmel,24c01", 24c02);

At least the original syntax is not susceptible to this problem,
but of course as you say, it hides the of_ compatible string:
AT24_OF_DEVICE_ID(atmel, 24c01);
/* hides 'atmel,24c01' */

Pros and cons. Pick one.