[PATCH 2/3] serial: max3100: Improve a size determination in max3100_probe()

From: SF Markus Elfring
Date: Fri Dec 08 2017 - 15:13:03 EST


From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 8 Dec 2017 20:32:09 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---
drivers/tty/serial/max3100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c
index b7b7e6582f3f..00c0e650537d 100644
--- a/drivers/tty/serial/max3100.c
+++ b/drivers/tty/serial/max3100.c
@@ -761,7 +761,7 @@ static int max3100_probe(struct spi_device *spi)
return -ENOMEM;
}

- max3100s[i] = kzalloc(sizeof(struct max3100_port), GFP_KERNEL);
+ max3100s[i] = kzalloc(sizeof(*max3100s[i]), GFP_KERNEL);
if (!max3100s[i]) {
mutex_unlock(&max3100s_lock);
return -ENOMEM;
--
2.15.1