Re: [PATCH] tools/slabinfo-gnuplot: force to use bash shell

[Andrew Morton]

On Fri, 8 Dec 2017 19:33:15 +0900 Sergey Senozhatsky <sergey.senozhatsky.work@xxxxxxxxx> wrote:

> On (12/08/17 17:37), Liu, Changcheng wrote:
> > 
> > On some linux distributions, the default link of sh
> > is dash which deoesn't support split array like
> > ${var//,/ }
> > It's better to force to use bash shell directly.
> > 
> > Signed-off-by: Liu Changcheng <changcheng.liu@xxxxxxxxx>
> 
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>

It would be better to rewrite the script to avoid bashisms.  But...

akpm3:/usr/src/linux-4.15-rc2> grep -rl "/bin/bash" . | wc -l
164

I guess we lost that fight a long time ago.