Re: [PATCH v2] drivers: visorbus: move driver out of staging
From: Joe Perches
Date: Fri Dec 08 2017 - 17:13:28 EST
On Fri, 2017-12-08 at 21:55 +0000, Kershner, David A wrote:
> > -----Original Message-----
> > From: Joe Perches [mailto:joe@xxxxxxxxxxx]
> > Sent: Friday, December 8, 2017 11:53 AM
> > To: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>; Kershner, David A
> > <David.Kershner@xxxxxxxxxx>
> > Cc: jes.sorensen@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; driverdev-
> > devel@xxxxxxxxxxxxxxxxxxxxxx; *S-Par-Maintainer
> > <SParMaintainer@xxxxxxxxxx>; erik.arfvidson@xxxxxxxxx;
> > wadgaonkarsam@xxxxxxxxx
> > Subject: Re: [PATCH v2] drivers: visorbus: move driver out of staging
> >
> > On Fri, 2017-12-08 at 16:39 +0100, Greg KH wrote:
> > > On Thu, Dec 07, 2017 at 12:11:07PM -0500, David Kershner wrote:
> > > > Move the visorbus driver out of staging
>
> (drivers/staging/unisys/visorbus)
> > > > and to drivers/visorbus. Modify the configuration and makefiles so
>
> they
> > > > now reference the new location. The s-Par header file visorbus.h that
>
> is
> > > > referenced by all s-Par drivers, is being moved into include/linux.
> >
> > Perhaps moving visorbus.h and visorbus_private.h to
> > drivers/visorbus would be better than adding more
> > relatively localized #include files to include/linux/
> >
> > what about controlvmchannel?
> >
>
> The file visorbus.h is currently included by 4 drivers: visorbus and 3
> other drivers that are staying in staging for now, but we plan to move out
> soon.
OK.
Where do you plan on moving the 3 other drivers?
Today, these drivers (visorhba, visorinput, and visornic)
are all under the staging/unisys directory
visorbus -> drivers/visorbus
visorhba -> ?
visorinput -> ?
visornic -> ?
Perhaps all these, including visorbus, should be under virt/
or perhaps visorbus should be under virt/ and the others
under drivers/virt/