Re: [PATCH] platform/x86: intel-vbtn: Simplify autorelease logic
From: Darren Hart
Date: Fri Dec 08 2017 - 18:48:11 EST
On Sat, Dec 09, 2017 at 12:28:18AM +0100, Stefan Brüns wrote:
> On Saturday, December 9, 2017 12:07:08 AM CET Darren Hart (VMware) wrote:
> > The new notify_handler logic determining if autorelease should be used or
> > not is a bit awkward, and can result in more than one call to
> > sparse_keymap_report_event for the same event (scancode). The nesting
> > and long lines also made it difficult to read.
> >
> > Simplify the logic by eliminating a level of nesting with a goto and
> > always calculate autorelease and val so we can make a single call to
> > sparse_keymap_report_event.
> >
> > Signed-off-by: Darren Hart (VMware) <dvhart@xxxxxxxxxxxxx>
> > Cc: Stefan Brüns <stefan.bruens@xxxxxxxxxxxxxx>
> > Cc: AceLan Kao <acelan.kao@xxxxxxxxxxxxx>
> > ---
> > Note: This is based on top of Stefan's v2 patch series for intel-vbtn,
> > currently in my review-dvhart branch.
>
> Hi Darren,
>
> is this tree publically available?
Yes, in the tree listed in MAINTAINERS:
git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git
which is actually an alias I should now update to:
git://git.infradead.org/linux-platform-drivers-x86.git
Note that the review-* branches exist for CI/CD tooling and will rebase often.
testing, fixes, and for-next are the only branches considered to be "published".
--
Darren Hart
VMware Open Source Technology Center