Re: [PATCH v2 1/2] staging: rtl8712: Cleanup checkpatch issue WARNING:LONG_LINE

[Larry Finger]

On 12/09/2017 05:11 AM, Neil Singh wrote:
> Cleanup below checkpatch issue:
>
> WARNING:LONG_LINE: line over 80 characters
> 1000: FILE: rtl871x_security.c:1000:
> +static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint qc_exists,
>
> Signed-off-by: Neil Singh <neil2468@xxxxxxxxx>
> ---
>   drivers/staging/rtl8712/rtl871x_security.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_security.c b/drivers/staging/rtl8712/rtl871x_security.c
> index 56d36f6..77a5f5d 100644
> --- a/drivers/staging/rtl8712/rtl871x_security.c
> +++ b/drivers/staging/rtl8712/rtl871x_security.c
> @@ -997,7 +997,8 @@ static void construct_mic_header2(u8 *mic_header2, u8 *mpdu, sint a4_exists,
>   /* Builds the last MIC header block from        */
>   /* header fields.                               */
>   /************************************************/
> -static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint qc_exists,
> +static void construct_ctr_preload(u8 *ctr_preload,
> +			   sint a4_exists, sint qc_exists,
>   			   u8 *mpdu, u8 *pn_vector, sint c)
>   {
>   	sint i;

Did you run checkpatch on these patches? My system reports the following:

-------
patch_1
-------
WARNING: A patch subject line should describe the change not the tool that found it
#95:
Subject: [PATCH v2 1/2] staging: rtl8712: Cleanup checkpatch issue WARNING:LONG_LINE

CHECK: Alignment should match open parenthesis
#125: FILE: drivers/staging/rtl8712/rtl871x_security.c:1001:
+static void construct_ctr_preload(u8 *ctr_preload,
+                          sint a4_exists, sint qc_exists,

-------
patch_2
-------
WARNING: A patch subject line should describe the change not the tool that found it
#95:
Subject: [PATCH v2 2/2] staging: rtl8712: Cleanup checkpatch issues CODE_INDENT 
and LEADING_SPACE

Larry