Re: [PATCH v1 1/2] dt-bindings: Add binding for Sitronix ST7735R display panels

[David Lechner]

On 12/08/2017 03:41 PM, Noralf TrÃnnes wrote:
> Den 29.11.2017 04.01, skrev David Lechner:
> > This adds a new device tree binding for Sitronix ST7735R display panels,
> > such as the Adafruit 1.8" TFT.
> >
> > Signed-off-by: David Lechner <david@xxxxxxxxxxxxxx>
> > ---
> > Â .../bindings/display/sitronix,st7735r.txtÂÂÂÂÂÂÂÂÂ | 35 
> > ++++++++++++++++++++++
> > Â 1 file changed, 35 insertions(+)
> > Â create mode 100644 
> > Documentation/devicetree/bindings/display/sitronix,st7735r.txt
> >
> > diff --git 
> > a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt 
> > b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt
> > new file mode 100644
> > index 0000000..bbb8ba6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt
> > @@ -0,0 +1,35 @@
> > +Sitronix ST7735R display panels
> > +
> > +This binding is for display panels using a Sitronix ST7735R 
> > controller in SPI
> > +mode.
> > +
> > +Required properties:
> > +- compatible:ÂÂÂ "sitronix,st7735r-jd-t18003-t01"
> > +- dc-gpios:ÂÂÂ Display data/command selection (D/CX)
> > +- reset-gpios:ÂÂÂ Reset signal (RSTX)
>
> I'm wondering if this should be optional.
>
> Even though the display needs the reset line to be driven, it doesn't
> have to be so by a gpio, I believe you can even get away with just
> using a resistor as a reset circuit.
>
> Not terribly important, it's up to you.

It can be made optional later if needed, so I'm going to leave it as-is.