Re: [PATCH 1/1] futex: futex_wake_op, fix sign_extend32 sign bits

[Linus Torvalds]

On Thu, Nov 30, 2017 at 6:35 AM, Jiri Slaby <jslaby@xxxxxxx> wrote:
> sign_extend32 counts the sign bit parameter from 0, not from 1. So we
> have to use "11" for 12th bit, not "12".

This interface is crap. It really doesn't make much sense. I wonder
how many people have gotten this wrong, but it's hard to tell.

I'm applying this directly to my tree since I didn't see anybody else
react to it, but the whole pattern worries me.

Also, clearly nobody actually uses the odder corners of futex ops
anyway. Maybe we should deprecate them entirely?

Jiri, did you notice by testing, or what?

      Linus