Re: [PATCH] mm/slab: Do not hash pointers when debugging slab

From: Geert Uytterhoeven
Date: Mon Dec 11 2017 - 03:08:25 EST


Hi Linus,

On Sun, Dec 10, 2017 at 9:45 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Dec 7, 2017 at 2:17 AM, Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx> wrote:
>> - pr_err("Slab corruption (%s): %s start=%p, len=%d\n",
>> + pr_err("Slab corruption (%s): %s start=%px, len=%d\n",
>> print_tainted(), cachep->name,
>> realobj, size);
>
> and here, is the pointer actually interesting, or should we just give
> the offset to the allocation?

The pointer may help to identify e.g. an empty list_head in the written data.

> But if the pointer is interesting, then ack.

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds