Re: [PATCH 05/20] ARM: dts: aspeed: Add proper clock references
From: Arnd Bergmann
Date: Mon Dec 11 2017 - 03:09:55 EST
On Mon, Dec 11, 2017 at 6:06 AM, Joel Stanley <joel@xxxxxxxxx> wrote:
> The existing device trees use fixed-clocks in order to boot without a
> clk driver. The newly added clk driver provides proper clock support,
> including gating, so we move the device trees over to properly request
> clocks.
>
> Signed-off-by: Joel Stanley <joel@xxxxxxxxx>
Can you clarify here whether this will break running old kernels with
new DT files or vice versa, and why this is ok here?
I assume you have thought about it carefully, but I'd still like to document
every time we intentionally break compatibility like this. It looks like
you too care to merge the driver changes and the DT binding change first,
so we don't get any bisection problems.
What I'm not completely clear about is the difference between the
"aspeed,g4-scu" binding and the "aspeed,ast2400-scu" binding.
They are listed as equal in
Documentation/devicetree/bindings/mfd/aspeed-scu.txt, so why do you
change it here?
Arnd