Re: [Intel-gfx] [PATCH] drm/i915: Use copy_from_user() in fence copying

From: Joonas Lahtinen
Date: Mon Dec 11 2017 - 04:34:29 EST


On Wed, 2017-12-06 at 12:28 -0800, Kees Cook wrote:
> There's no good reason to separate the access_ok() from the copy,
> especially since the access_ok() size is hard-coded instead of using
> sizeof(). Instead, just use copy_from_user() directly.
>
> Fixes: cf6e7bac6357 ("drm/i915: Add support for drm syncobjs")

There's been request to reduce the amount of Fixes: tags that are not
actually fixing bugs. This seems more like an optimization.

References: has been suggested for these cases instead.

Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation