Re: [PATCH v1 1/2] drm/tegra: dc: Link DC1 to DC0 on Tegra20

[Thierry Reding]

On Mon, Dec 11, 2017 at 02:19:43AM +0300, Dmitry Osipenko wrote:
> HW reset isn't actually broken on Tegra20, but there is a dependency on
> first display controller to be taken out of reset for the second to be
> enabled successfully.
> 
> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> ---
>  drivers/gpu/drm/tegra/dc.c | 77 +++++++++++++++++++++++++++++-----------------
>  drivers/gpu/drm/tegra/dc.h |  4 ++-
>  2 files changed, 51 insertions(+), 30 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
> index fc70351b9017..6139d3e9cedf 100644
> --- a/drivers/gpu/drm/tegra/dc.c
> +++ b/drivers/gpu/drm/tegra/dc.c
> @@ -24,6 +24,8 @@
>  #include <drm/drm_atomic_helper.h>
>  #include <drm/drm_plane_helper.h>
>  
> +static struct tegra_dc *dc0;

I'd like to avoid the global variable. Perhaps you can use the
driver_for_each_device() or driver_find_device() functions to find the
correct device?

Thierry

Attachment: signature.asc
Description: PGP signature