Re: [PATCH 03/20] ARM: dts: aspeed-g4: Correct VUART IRQ number
From: Arnd Bergmann
Date: Mon Dec 11 2017 - 06:38:35 EST
On Mon, Dec 11, 2017 at 11:44 AM, Joel Stanley <joel@xxxxxxxxx> wrote:
> On Mon, Dec 11, 2017 at 6:28 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
>> On Mon, Dec 11, 2017 at 6:06 AM, Joel Stanley <joel@xxxxxxxxx> wrote:
>>> This should have always been 8.
>>>
>>> Signed-off-by: Joel Stanley <joel@xxxxxxxxx>
>>
>> As this is a bugfix, should we backport it to stable kernels? When you
>> fix a bug,
>> I generally recommend including a 'Fixes' tag with the commit ID of the patch
>> that introduced the problem, and either a 'Cc: stable@xxxxxxxxxxxxxxx' tag
>> if you want it backported, or an explanation in the changelog why it should
>> not get backported. This really helps Greg and the other stable maintainers
>> trying to make a decision what to backport and what not.
>
> We could do this, and I generally follow the practice of adding Fixes
> tags. I hadn't because without an upstream clock driver, the Aspeed
> port is not usable by anyone without making modifications. We're
> really depending on getting that code merged.
>
> I will send it as a fix to 4.15. Do you mind taking individual patches
> for the arm dt tree, or would you prefer a pull request?
For bugfixes, we don't distinguish between DT and other fixes. If it's
a single patch, a pull request works just as well as a emailed patch,
your choice.
Arnd