Re: [PATCH 0/2] acpi, x86: Add SPCR table support

From: Ingo Molnar
Date: Mon Dec 11 2017 - 09:42:56 EST



* Prarit Bhargava <prarit@xxxxxxxxxx> wrote:

> If I disable "Serial Port Console Debug" in my BIOS I still see the SPCR configured:
>
> [root@prarit-lab ~]# dmesg | grep SPCR
> [ 0.000000] ACPI: SPCR 0x0000000069031000 000050 (v01
> 00000000 00000000)
>
> AFAICT the SPCR is always enabled on some systems.

Fair enough.

> > If so then we should pick up that serial console configuration and activate it,
> > regardless of any kernel boot options!
>
> I'm worried about someone who doesn't want a console on ttyS0 suddenly ending up
> with one. The SPCR could contain incorrect data, etc.

Yeah, that's not good.

Thanks,

Ingo