Re: [PATCH RT 1/9] Revert "fs: jbd2: pull your plug when waiting for space"

From: Sebastian Andrzej Siewior
Date: Mon Dec 11 2017 - 10:37:37 EST


On 2017-12-08 13:15:24 [-0500], Steven Rostedt wrote:
> On Mon, 4 Dec 2017 09:45:45 +0100
> Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> wrote:
>
> > On 2017-12-01 20:36:59 [-0500], Steven Rostedt wrote:
> > > 4.4.102-rt117-rc1 stable review patch.
> > > If anyone has any objections, please let me know.
> >
> > Same comment as in the 4.9.65-rt57-rc2 review (that you might need
> > locking-rt-mutex-fix-deadlock-in-device-mapper-block.patch).
>
> Now it does appear I'm missing that for 4.4. I wonder why I didn't pull
> it in there. Perhaps it wasn't needed, which means this isn't needed
> either.

I strongly suggest to include "locking/rt-mutex: fix deadlock in device
mapper / block-IO". We had a workaround in the jbd/ext3 code which then
moved into jbd2/ext4 after people complained about the same problem. I
wasn't sure about the root-cause back then but now with explanation we
have in the fix patch I'm sure this is one of the bugs we have since day
one.

> Thanks!
>
> -- Steve

Sebastian