Re: [PATCH] i2c: update i2c-dev.h warning in documentation
From: Jonathan Corbet
Date: Mon Dec 11 2017 - 18:20:14 EST
On Sat, 9 Dec 2017 23:10:58 +0300
Cengiz Can <cengizc@xxxxxxxxx> wrote:
> `dev-interface` document gives examples for accessing i2c from
> userspace.
>
> There's a note warning developers about the different `i2c-dev.h` header
> files which were shipped with the kernel and i2c-tools separately.
>
> However, these commits in i2c-tools repository suggests that the header
> files are now identical (in functionality) and `i2c_*` functions are now
> defined in a separate header called `i2c/smbus.h`, which is distributed
> with i2c-tools:
>
> commit 652619121974 ("Minimize differences with kernel flavor")
> commit 93caf007f4cb ("Move SMBus helper functions to include/i2c/smbus.h")
>
> Thus, I've converted the warning paragraph into a historical note and
> updated the suggested header files.
>
> Signed-off-by: Cengiz Can <cengizc@xxxxxxxxx>
So this seems like a worthwhile change, but the patch contains a number of
unrelated changes, mostly white-space stuff it seems. Can you clean that
up and resend?
Thanks,
jon