Re: [PATCH 1/1] scsi: fnic: add a space after %p in printf format

From: Bart Van Assche
Date: Mon Dec 11 2017 - 18:34:45 EST


On Mon, 2017-12-11 at 23:54 +0100, Nicolas Iooss wrote:
> On Mon, Dec 11, 2017 at 11:22 PM, Bart Van Assche
> <Bart.VanAssche@xxxxxxx> wrote:
> > On Sun, 2017-12-10 at 20:23 +0100, Nicolas Iooss wrote:
> > > - "hdr status = %s tag = 0x%x sc = 0x%p"
> > > + "hdr status = %s tag = 0x%x sc = 0x%p "
> > > "scsi_status = %x residual = %d\n",
> >
> > Since the %p format specifier already inserts a 0x prefix, shouldn't 0x%p be changed
> > into %p?
>
> Does it? On the kernel I use it does not, and the documentation for %p
> does not show a 0x prefix
> (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/printk-formats.txt?h=v4.15-rc3#n57).

Please ignore my comment.

Bart.