Re: [PATCH 4.4 20/49] usbip: tools: Install all headers needed for libusbip development

[Greg Kroah-Hartman]

On Tue, Dec 12, 2017 at 12:13:59AM +0000, alexander.levin@xxxxxxxxxxx wrote:
> On Sat, Dec 09, 2017 at 08:41:54AM +0100, Greg Kroah-Hartman wrote:
> >On Sat, Dec 09, 2017 at 06:16:04AM +0000, alexander.levin@xxxxxxxxxxx wrote:
> >> On Fri, Dec 08, 2017 at 03:56:40AM +0000, Ben Hutchings wrote:
> >> >On Thu, 2017-12-07 at 14:07 +0100, Greg Kroah-Hartman wrote:
> >> >> 4.4-stable review patch.  If anyone has any objections, please let me know.
> >> >>
> >> >> ------------------
> >> >>
> >> >> From: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> >> >>
> >> >>
> >> >> [ Upstream commit c15562c0dcb2c7f26e891923b784cf1926b8c833 ]
> >> >>
> >> >> usbip_host_driver.h now depends on several additional headers, which
> >> >> need to be installed along with it.
> >> >>
> >> >> Fixes: 021aed845303 ("staging: usbip: userspace: migrate usbip_host_driver ...")
> >> >> Fixes: 3391ba0e2792 ("usbip: tools: Extract generic code to be shared with ...")
> >> >> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> >> >> Acked-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
> >> >> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> >> >> Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxx>
> >> >> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> >> >> ---
> >> >>  tools/usb/usbip/Makefile.am |    3 ++-
> >> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >> >>
> >> >> --- a/tools/usb/usbip/Makefile.am
> >> >> +++ b/tools/usb/usbip/Makefile.am
> >> >> @@ -1,6 +1,7 @@
> >> >>  SUBDIRS := libsrc src
> >> >>  includedir = @includedir@/usbip
> >> >>  include_HEADERS := $(addprefix libsrc/, \
> >> >> -		     usbip_common.h vhci_driver.h usbip_host_driver.h)
> >> >> +		     usbip_common.h vhci_driver.h usbip_host_driver.h \
> >> >> +		     list.h sysfs_utils.h usbip_host_common.h)
> >> >
> >> >usbip_host_common.h was added in 4.7 (by the second commit listed
> >> >above), so for 4.4 and 3.18 it should not be added to this list.
> >>
> >> Thanks Ben!
> >>
> >> Greg, I'm not sure how to send you fixes for patches currently in your
> >> -rc cycle, since ideally you would just remove them instead of
> >> reverting. Any ideas?
> >
> >Yes, I can just drop them from the queue.  I'll go through all of these
> >later this evening when I get back to the keyboard...
> 
> If you regenerate trees based on the queue, can I send you patches for
> your stable-queue to remove commits after you've pulled from me but
> before you release it?

You can, but no one has ever done that before, could be an interesting
thing to attempt :)

greg k-h