Re: [PATCH] mm, hugetlbfs: include mm.h for vm_operations_struct

From: Dan Williams
Date: Tue Dec 12 2017 - 03:05:15 EST


On Mon, Dec 11, 2017 at 11:47 PM, Michal Hocko <mhocko@xxxxxxxxxx> wrote:
> On Mon 11-12-17 17:21:27, Arnd Bergmann wrote:
>> The infiniband umem code causes a build failure in some configurations:
>>
>> In file included from drivers/infiniband/core/umem_odp.c:41:0:
>> include/linux/hugetlb.h: In function 'vma_kernel_pagesize':
>> include/linux/hugetlb.h:262:32: error: dereferencing pointer to incomplete type 'const struct vm_operations_struct'
>>
>> Including the header file that defines the structure is sufficient to
>> avoid this.
>>
>> Fixes: ac9284a6b670 ("mm, hugetlbfs: introduce ->pagesize() to vm_operations_struct")
>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> I've tried to do the same but the compilation failed for other
> arches/configs. See http://lkml.kernel.org/r/20171210113715.GE20234@xxxxxxxxxxxxxx

Andrew, Stephen, please drop this ->pagesize() patch out of -mm and
-next. I'll circle back once I have this include dependency fixed up.
Thanks for the reports and sorry for the noise.