Re: [PATCH 1/2] x86: consider effective protection attributes in W+X check

From: Jan Beulich
Date: Tue Dec 12 2017 - 05:44:04 EST


>>> On 12.12.17 at 11:36, <mingo@xxxxxxxxxx> wrote:

> * Jan Beulich <JBeulich@xxxxxxxx> wrote:
>
>> Using just the leaf page table entry flags would cause a false warning
>> in case _PAGE_RW is clear or _PAGE_NX is set in a higher level entry.
>
> Good find - I assume this bug can cause both false positives and false
> negatives
> as well, right?

Yes, albeit I'm not aware of any outside of Xen (with that other patch
applied).

Jan