[PATCH] drivers: base: power: Fix GFP_KERNEL in spinlock context
From: shrikant . maurya
Date: Tue Dec 12 2017 - 08:46:01 EST
From: Shrikant Maurya <shrikant.maurya@xxxxxxxxxxxx>
As reported by Jia-Ju Bai (https://lkml.org/lkml/2017/12/11/872):
API's are using GFP_KERNEL to allocate memory which may sleep.
To ensure atomicity such allocations must be avoided in critical
sections under spinlock.
Fixed by replacing GFP_KERNEL to GFP_ATOMIC.
Reported-by: Jia-Ju Bai <baijiaju1990@xxxxxxxxx>
Signed-off-by: Shrikant Maurya <shrikant.maurya@xxxxxxxxxxxx>
Signed-off-by: Suniel Mahesh <sunil.m@xxxxxxxxxxxx>
Signed-off-by: Raghu Bharadwaj <raghu@xxxxxxxxxxxx>
Signed-off-by: Karthik Tummala <karthik@xxxxxxxxxxxx>
---
Note:
- Patch was compile tested and built(ARCH=arm) on linux-next
(latest).
- No build issues reported.
---
drivers/base/power/wakeup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c
index 38559f0..de56952 100644
--- a/drivers/base/power/wakeup.c
+++ b/drivers/base/power/wakeup.c
@@ -92,11 +92,11 @@ struct wakeup_source *wakeup_source_create(const char *name)
{
struct wakeup_source *ws;
- ws = kmalloc(sizeof(*ws), GFP_KERNEL);
+ ws = kmalloc(sizeof(*ws), GFP_ATOMIC);
if (!ws)
return NULL;
- wakeup_source_prepare(ws, name ? kstrdup_const(name, GFP_KERNEL) : NULL);
+ wakeup_source_prepare(ws, name ? kstrdup_const(name, GFP_ATOMIC) : NULL);
return ws;
}
EXPORT_SYMBOL_GPL(wakeup_source_create);
--
1.9.1