Re: [PATCH v3 1/3] interconnect: Add generic on-chip interconnect API

[Georgi Djakov]

Hi Amit,

On 12/08/2017 08:38 PM, Amit Kucheria wrote:
> On Fri, Sep 8, 2017 at 10:48 PM, Georgi Djakov <georgi.djakov@xxxxxxxxxx> wrote:
>> This patch introduce a new API to get requirements and configure the
>> interconnect buses across the entire chipset to fit with the current demand.
>>
>> The API is using a consumer/provider-based model, where the providers are
>> the interconnect buses and the consumers could be various drivers.
>> The consumers request interconnect resources (path) between endpoints and
>> set the desired constraints on this data flow path. The providers receive
>> requests from consumers and aggregate these requests for all master-slave
>> pairs on that path. Then the providers configure each participating in the
>> topology node according to the requested data flow path, physical links and
>> constraints. The topology could be complicated and multi-tiered and is SoC
>> specific.
>>
>> Signed-off-by: Georgi Djakov <georgi.djakov@xxxxxxxxxx>

[..]

>> +inline int interconnect_set(struct interconnect_path *path,
>> +                           struct interconnect_creq *creq);
> 
> Remove the semi colon

Thanks! Fixed.

> 
>> +{
>> +       return -ENOTSUPP
> 
> return ERR_PTR(-ENOTSUPP);

I do not agree here. It should be left as is, because the function
returns int.

> 
>> +}
>> +
> 
> This breaks the build with INTERCONNECT disabled in Kconfig.

Ok, i have fixed this as well.

Thanks,
Georgi