Re: [PATCH] USB: serial: ark3116.c: Remove unused TIOCSSERIAL case from ioctl

[Oliver Neukum]

Am Mittwoch, den 13.12.2017, 12:30 +0300 schrieb Mikhail Zaytsev:
> +#define RS232_VENDOR 0x6547
> +#define RS232_PRODUCT 0x0232
> +#define IRDA_VENDOR 0x18ec
> +#define IRDA_PRODUCT 0x3118
> Â
> Â/* usb timeout of 1 second */
> Â#define ARK_TIMEOUT 1000
> Â
> Âstatic const struct usb_device_id id_table[] = {
> -ÂÂÂÂÂÂÂ{ USB_DEVICE(0x6547, 0x0232) },
> -ÂÂÂÂÂÂÂ{ USB_DEVICE(0x18ec, 0x3118) },ÂÂÂÂÂÂÂÂÂ/* USB to IrDA adapter */
> +ÂÂÂÂÂÂÂ{ USB_DEVICE(RS232_VENDOR, RS232_PRODUCT) },
> +ÂÂÂÂÂÂÂ{ USB_DEVICE(IRDA_VENDOR, IRDA_PRODUCT) }, /* USB to IrDA adapter */

Hi,

what is the purpose of this change? It just makes it harder to grep.
The constants are arbitrary and they are clearly device IDs.

ÂÂÂÂÂÂÂÂRegards
ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂOliver