Re: [PATCH 1/4] cpufreq: schedutil: Initialize sg_cpu->flags to 0

From: Viresh Kumar
Date: Wed Dec 13 2017 - 06:22:19 EST


On 13-12-17, 12:13, Juri Lelli wrote:
> Hi Viresh,
>
> On 13/12/17 15:23, Viresh Kumar wrote:
> > Initializing sg_cpu->flags to SCHED_CPUFREQ_RT has no obvious benefit.
> > The flags field wouldn't be used until the utilization update handler is
> > called for the first time, and once that is called we will overwrite
> > flags anyway.
> >
> > Initialize it to 0.
> >
> > Change-Id: I028dbb40c5c242cff52fe1b14aeaff37f29a2f8d
>
> Without ^

Wow. I have a script in place to make sure this doesn't get added. Not sure how
this got added here, while its not present in any of the other patches.

> > Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>
> Reviewed-by: Juri Lelli <juri.lelli@xxxxxxxxxx>
>
> Best,
>
> - Juri

--
viresh