Re: [PATCH 01/10] ASoC: tlv320aic32x4: Remove filename from header and switch to SPDX
From: Andrew F. Davis
Date: Wed Dec 13 2017 - 10:50:52 EST
On 12/13/2017 09:44 AM, Andrew F. Davis wrote:
> On 12/12/2017 08:19 PM, Joe Perches wrote:
>> On Tue, 2017-12-12 at 16:43 -0600, Andrew F. Davis wrote:
>>> The filename is often wrong after moves and adds nothing of value,
>>> lets drop it. While already here, switch to SPDX.
>> []
>>> diff --git a/sound/soc/codecs/tlv320aic32x4-i2c.c b/sound/soc/codecs/tlv320aic32x4-i2c.c
>> []
>>> @@ -1,21 +1,10 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>>> /*
>>> - * linux/sound/soc/codecs/tlv320aic32x4-i2c.c
>>> - *
>>> * Copyright 2011 NW Digital Radio
>>> *
>>> * Author: Jeremy McDermond <nh6z@xxxxxxxx>
>>> *
>>> * Based on sound/soc/codecs/wm8974 and TI driver for kernel 2.6.27.
>>> - *
>>> - * This program is free software; you can redistribute it and/or modify
>>> - * it under the terms of the GNU General Public License as published by
>>> - * the Free Software Foundation; either version 2 of the License, or
>>> - * (at your option) any later version.
>>> - *
>>> - * This program is distributed in the hope that it will be useful,
>>> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>>> - * GNU General Public License for more details.
>>
>> nack. Note the "(at your option) any later version"
>>
>> If you are going to update to spdx and remove the old license
>> verbiage, make sure you are adding the correct spdx tag.
>>
>
> My bad, will fix.
>
> By the way, do you like these spdx update patch? Or would you rather I
> drop this one and wait to let some script do it for the whole subsystem?
>
This last question was directed at Mark btw :)
Actually, I'll just drop the spdx change from this patch, no reason to
do these manually.