Re: [PATCH] usbip: fix usbip bind writing random string after command in match_busid

[Shuah Khan]

On 12/13/2017 04:07 AM, Juan Zea wrote:
> usbip bind writes commands followed by random string when writing to
> match_busid attribute in sysfs, caused by using full variable size
> instead of string length.
> 
> Signed-off-by: Juan Zea <juan.zea@xxxxxxxxxx>
> ---
>  tools/usb/usbip/src/utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/usb/usbip/src/utils.c b/tools/usb/usbip/src/utils.c
> index 2b3d6d2..ea1a1af 100644
> --- a/tools/usb/usbip/src/utils.c
> +++ b/tools/usb/usbip/src/utils.c
> @@ -42,7 +42,7 @@ int modify_match_busid(char *busid, int add)
>                 snprintf(command, SYSFS_BUS_ID_SIZE + 4, "del %s", busid);
>  
>         rc = write_sysfs_attribute(match_busid_attr_path, command,
> -                                  sizeof(command));
> +                                  strlen(command));
>         if (rc < 0) {
>                 dbg("failed to write match_busid: %s", strerror(errno));
>                 return -1;
> 

Why not use the return value from snprintf() for length, instead of calling
strlen(command)?

thanks,
-- Shuah