Re: [PATCH v3 net-next] net: ethernet: ti: cpdma: correct error handling for chan create
From: David Miller
Date: Wed Dec 13 2017 - 15:51:31 EST
From: Ivan Khoronzhuk <ivan.khoronzhuk@xxxxxxxxxx>
Date: Tue, 12 Dec 2017 23:06:35 +0200
> It's not correct to return NULL when that is actually an error and
> function returns errors in any other wrong case. In the same time,
> the cpsw driver and davinci emac doesn't check error case while
> creating channel and it can miss actual error. Also remove WARNs
> replacing them on dev_err msgs.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@xxxxxxxxxx>
Applied.