Re: [PATCH] pinctrl: axp209: dereference pointer after it's been set

[Chen-Yu Tsai]

On Wed, Dec 13, 2017 at 5:20 PM, Mylene JOSSERAND
<mylene.josserand@xxxxxxxxxxxxxxxxxx> wrote:
> Hello Quentin,
>
> Le Wed, 13 Dec 2017 09:55:03 +0100,
> Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxx> a Ãcrit :
>
>> The number of GPIOs is gotten from a field within the structure
>> referenced in the of_device.data but it was actually read before it was
>> retrieved, thus it was dereferencing a null pointer.
>>
>> Set the number of GPIOs after retrieving of_device.data.
>>
>> Fixes: e1190083b89b ("pinctrl: axp209: add support for AXP813 GPIOs")
>>
>> Signed-off-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxx>
>> Reported-by: MylÃne Josserand <mylene.josserand@xxxxxxxxxxxxxxxxxx>
>
> Tested-by: MylÃne Josserand <mylene.josserand@xxxxxxxxxxxxxxxxxx>

Acked-by: Chen-Yu Tsai <wens@xxxxxxxx>