Re: [PATCH 00/13] Updates for QCOM Alpha PLL

[Abhishek Sahu]

On 2017-12-14 03:53, Stephen Boyd wrote:
> On 12/11, Abhishek Sahu wrote:
> > On 2017-12-09 05:46, Stephen Boyd wrote:
> > >On 12/08, Abhishek Sahu wrote:
> > >>On 2017-12-07 11:53, Stephen Boyd wrote:
> > >>>On 09/28, Abhishek Sahu wrote:
> > >>>>This patch series does the miscellaneous changes in QCOM Alpha PLL
> > >>>>operation and structure to support other types of Alpha PLLâs.
> > >>>>
> > >>>>1. It adds the pll_type which will be used for determining all
> > >>>>   the properties of Alpha PLL.
> > >>>>2. It adds the support for Brammo and Huayra PLLâs for which
> > >>>>   the support is not available in existing alpha PLL code.
> > >>>>3. There wonât be any change in existing users of Alpha PLLâs
> > >>>>   since all the newly added code will be under flag for the default
> > >>>>   PLL operations.
> > >>>>
> > >>>
> > >>>Ok. I took a long look at this today. I rewrote a bunch of stuff.
> > >>
> > >> Thanks Stephen for reviewing the changes and making the code
> > >> cleaner. I checked all the code changes and everything looks
> > >> good. It will work for all of our requirement. I will check
> > >> with other PLL users also once and then update the patch
> > >> series with all your suggested code changes after complete
> > >> testing.
> > >
> > >Ok. Please don't resend. I've pushed out the branch to clk-next,
> > >and it can be adjusted if needed, or dropped and rewritten if
> > >something is totally busted.
> >
> >  Thanks Stephen for your great help and support.
> >  It seems, we are getting the error in the following error with these
> >  patches because of missing EXPORT_SYMBOL_GPL for
> >  clk_alpha_pll_regs and clk_hw_is_enabled.
> >
> >
> > ERROR: "clk_alpha_pll_regs" [drivers/clk/qcom/mmcc-msm8996.ko]
> > undefined!
> >
> > ERROR: "clk_hw_is_enabled" [drivers/clk/qcom/clk-qcom.ko] undefined!
> >
> > Caused by commits
> >
> >   d1506b749e92 ("clk: qcom: support for alpha pll properties")
> >   e66a4d6d0081 ("clk: qcom: support for dynamic updating the PLL")
> >   301803e6013b ("clk: qcom: support Huayra type Alpha PLL")
>
> Yep. I'll export the regs and remove the clk_hw_is_enabled()
> usage. Should be possible to do that inside the ops directly
> instead of going through the framework for it.

 Thanks Stephen for updating the patches :-)

 Correct. clk_alpha_pll_is_enabled can do that.