Re: [PATCH v6 00/14] soundwire: Add a new SoundWire subsystem
From: Vinod Koul
Date: Thu Dec 14 2017 - 05:49:45 EST
On Thu, Dec 14, 2017 at 08:35:08AM +0100, Greg Kroah-Hartman wrote:
> On Thu, Dec 14, 2017 at 11:19:31AM +0530, Vinod Koul wrote:
> > Changes in v6:
> > - Add reviewed/acked tags from Philippe, Pierre, Takashi and Greg
> > - Fix nitpicks from Takashi
> > - Drop the sysfs patch for now
>
> Wait, why drop the sysfs patch entirely? You need those attributes,
> right? You also need to document the existing sysfs files in
> Documentation/ABI/ for the class/device files you create in this patch
> series, so that needs to be done before this patch series can be
> accepted.
Well the sysfs patch is a standalone patch which contains the attributes. So
I dropped that "for this series" and plan to submit after reworking.
The rest of the code doesn't depend on it, so is fine.
I thought it is an okay kernel practice to drop patches with issues, merge the
rest and come back after fixing the issue. This is my plan for this as well.
Thanks
--
~Vinod