Re: [PATCH v2 net-next 0/3] add VLAN support to DSA MT7530

[David Miller]

From: <sean.wang@xxxxxxxxxxxx>
Date: Wed, 13 Dec 2017 12:01:10 +0800

> From: Sean Wang <sean.wang@xxxxxxxxxxxx>
> 
> Changes since v1:
> - fix up the typo
> - prefer ordering declarations longest to shortest
> - update that vlan_prepare callback should not change any state
> - use lower case letter for function naming
> 
> The patchset extends DSA MT7530 to VLAN support through filling required
> callbacks in patch 1 and merging the special tag with VLAN tag in patch 2
> for allowing that the hardware can handle these packets with VID from the
> CPU port.

This doesn't even compile:

drivers/net/dsa/mt7530.c: In function ʽmt7530_port_vlan_addʼ:
drivers/net/dsa/mt7530.c:1131:6: warning: unused variable ʽretʼ [-Wunused-variable]
  int ret;
      ^~~
drivers/net/dsa/mt7530.c: At top level:
drivers/net/dsa/mt7530.c:1324:23: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .port_vlan_prepare = mt7530_port_vlan_prepare,
                       ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/mt7530.c:1324:23: note: (near initialization for ʽmt7530_switch_ops.port_vlan_prepareʼ)
drivers/net/dsa/mt7530.c:1325:20: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .port_vlan_add  = mt7530_port_vlan_add,
                    ^~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/mt7530.c:1325:20: note: (near initialization for ʽmt7530_switch_ops.port_vlan_addʼ)
cc1: some warnings being treated as errors