Re: [PATCH 4.4 05/27] x86/efi: Build our own page table structures

[Greg Kroah-Hartman]

On Tue, Dec 12, 2017 at 05:24:32PM +0000, Ghannam, Yazen wrote:
> > -----Original Message-----
> > From: Greg Kroah-Hartman [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> > Sent: Sunday, December 10, 2017 4:27 PM
> > To: Ben Hutchings <ben.hutchings@xxxxxxxxxxxxxxx>; Ghannam, Yazen
> > <Yazen.Ghannam@xxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx; Matt Fleming
> > <matt@xxxxxxxxxxxxxxxxxxx>; Borislav Petkov <bp@xxxxxxx>; Andrew
> > Morton <akpm@xxxxxxxxxxxxxxxxxxxx>; Andy Lutomirski
> > <luto@xxxxxxxxxxxxxx>; Andy Lutomirski <luto@xxxxxxxxxx>; Ard Biesheuvel
> > <ard.biesheuvel@xxxxxxxxxx>; Borislav Petkov <bp@xxxxxxxxx>; Brian Gerst
> > <brgerst@xxxxxxxxx>; Dave Jones <davej@xxxxxxxxxxxxxxxxx>; Denys
> > Vlasenko <dvlasenk@xxxxxxxxxx>; H. Peter Anvin <hpa@xxxxxxxxx>; Linus
> > Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>; Peter Zijlstra
> > <peterz@xxxxxxxxxxxxx>; Sai Praneeth Prakhya
> > <sai.praneeth.prakhya@xxxxxxxxx>; Stephen Smalley <sds@xxxxxxxxxxxxx>;
> > Thomas Gleixner <tglx@xxxxxxxxxxxxx>; Toshi Kani <toshi.kani@xxxxxx>;
> > linux-efi@xxxxxxxxxxxxxxx; Ingo Molnar <mingo@xxxxxxxxxx>; Ghannam,
> > Yazen <Yazen.Ghannam@xxxxxxx>; Alex Thorlton <athorlton@xxxxxxx>
> > Subject: Re: [PATCH 4.4 05/27] x86/efi: Build our own page table structures
> > 
> > On Thu, Dec 07, 2017 at 10:43:49PM +0000, Ben Hutchings wrote:
> > > On Mon, 2017-12-04 at 16:59 +0100, Greg Kroah-Hartman wrote:
> > > > 4.4-stable review patch.  If anyone has any objections, please let me
> > know.
> > > >
> > > > ------------------
> > > >
> > > > From: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx>
> > > >
> > > > commit 67a9108ed4313b85a9c53406d80dc1ae3f8c3e36 upstream.
> > > [...]
> > >
> > > It looks like this will cause regressions unless you also apply:
> > >
> > > 21cdb6b56843 x86/mm: Page align the '_end' symbol to avoid pfn
> > conversion bugs
> > > b61a76f8850d x86/efi: Map RAM into the identity page table for mixed
> > mode
> > > 753b11ef8e92 x86/efi: Setup separate EFI page tables in kexec paths
> > >
> > > and possibly also:
> > >
> > > 08914f436bdd x86/platform/UV: Bring back the call to map_low_mmrs in
> > uv_system_init
> > > 683ad8092cd2 x86/efi: Fix 7-parameter efi_call()s
> > > 80e75596079f efi: Convert efi_call_virt() to efi_call_virt_pointer()
> > > d1be84a232e3 x86/uv: Update uv_bios_call() to use efi_call_virt_pointer()
> > 
> > Ugh, that's a mess.  Yazen is the one who reported this patch, and 2
> > others, were needed to resolve an issue on their hardware.
> > 
> > Yazen, any thoughts here?  Should I just revert the 3 patches, or do you
> > also feel I need all 7 of these to ensure everything works properly?
> > 
> 
> I think it's okay to revert the 3 patches.

Ugh, messy.  Ok, all now reverted.

Thanks Ben for the review, much appreciated.

greg k-h