Re: [Y2038] [PATCH v2 04/10] arch: introduce CONFIG_64BIT_TIME

[Ben Hutchings]

On Mon, 2017-11-27 at 11:30 -0800, Deepa Dinamani wrote:
> There are a total of 53 system calls (aside from ioctl) that pass a time_t
> or derived data structure as an argument, and in order to extend time_t
> to 64-bit, we have to replace them with new system calls and keep providing
> backwards compatibility.
> 
> To avoid adding completely new and untested code for this purpose, we
> introduce a new CONFIG_64BIT_TIME symbol. Every architecture that supports
> new 64 bit time_t syscalls enables this config via ARCH_HAS_64BIT_TIME.
> 
> After this is done for all architectures, the CONFIG_64BIT_TIME symbol
> will be deleted.
> 
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Deepa Dinamani <deepa.kernel@xxxxxxxxx>
> ---
> Âarch/Kconfig | 11 +++++++++++
> Â1 file changed, 11 insertions(+)
> 
> diff --git a/arch/Kconfig b/arch/Kconfig
> index 4f03534bfa6b..11810c29c1fa 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -873,6 +873,17 @@ config OLD_SIGACTION
> Âconfig COMPAT_OLD_SIGACTION
> > Â	bool
> Â
> +config ARCH_HAS_64BIT_TIME
> +	def_bool n
> +
> +config 64BIT_TIME
> +	def_bool ARCH_HAS_64BIT_TIME
> +	help
> +	ÂÂThis should be selected by all architectures that need to support
> +	ÂÂnew system calls with a 64-bit time_t. This is relevant on all 32-bit
> +	ÂÂarchitectures, and 64-bit architectures as part of compat syscall
> +	ÂÂhandling.

Doesn't this text belong with ARCH_HAS_64BIT_TIME?

Ben.

> +
> Âconfig ARCH_NO_COHERENT_DMA_MMAP
> Â	bool
> Â
-- 
Ben Hutchings
Software Developer, Codethink Ltd.