Re: [PATCH V2] ACPI / LPSS: Add device link for CHT SD card dependency on I2C

[Rafael J. Wysocki]

On Thu, Dec 14, 2017 at 3:16 PM, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> On Thu, 2017-12-07 at 11:03 +0200, Adrian Hunter wrote:
>> Some Cherry Trail boards have a dependency between the SDHCI host
>> controller used for SD cards and an external PMIC accessed via I2C.
>> Add a
>> device link between the SDHCI host controller (consumer) and the I2C
>> adapter (supplier).
>>
>> This patch depends on a fix to devices links, namely commit
>> 0ff26c662d5f
>> ("driver core: Fix device link deferred probe"). And also either,
>> commit 126dbc6b49c8 ("PM: i2c-designware-platdrv: Clean up PM handling
>> in
>> probe"), or patch "PM / runtime: Fix handling of suppliers with
>> disabled
>> runtime PM".
>>
>
> Fine with me, though I think below comment worth to address.
>
>>
>> +static const struct x86_cpu_id cht_cpu[] = {
>> +     ICPU(INTEL_FAM6_ATOM_AIRMONT),  /* Braswell, Cherry
>> Trail */
>> +     {}
>> +};
>
> I would rather to modify ICPU() macro to accept driver data where we
> just pass an unsigned long value to be assigned as lpss_quirks and
> introduce another quirk.

Not really.

There are many instances of ICPU() already in the tree and updating
all of them is just not worth it.

If you can make the code cleaner without modifying that macro, go for it.

Thanks,
Rafael