Re: [PATCH v3] KVM: X86: Fix stack-out-of-bounds read in write_mmio

[Wanpeng Li]

2017-12-14 22:18 GMT+08:00 Darren Kenny <darren.kenny@xxxxxxxxxx>:
> Hi,
>
> I'm wondering about the change to trace_kvm_mmio() here, since it
> doesn't appear to be changing the use of it in
> virt/kvm/arm/mmio.c, e.g:
>
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/virt/kvm/arm/mmio.c#n114
>
> which seems to be still using it with a data value rather than a
> pointer like you've changed it to in the header.
>
> Should that also be modified to match? As it is, it would appear to
> cause a compilation error on ARM (though I've not confirmed).

Yeah, fix it in v4, https://lkml.org/lkml/2017/12/14/954 however, I
don't have an ARM environment to compile it though the change is very
simple.

Regards,
Wanpeng Li