Re: [PATCH 0/3] platform/x86: dell-laptop: All the warnings are resolved.

[Dhaval Shah]

Hi Andy Shevchenko,

Thanks for the review.
________________________________________
> From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Sent: Thursday, December 14, 2017 11:29 PM
> To: Dhaval Shah
> Cc: Matthew Garrett; Pali Rohár; Andy Shevchenko; Platform Driver; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 0/3] platform/x86: dell-laptop: All the warnings are resolved.
> 
> On Wed, Dec 13, 2017 at 10:13 AM, Dhaval Shah
> <dhaval.shah@xxxxxxxxxxxxxxx> wrote:
> > There are total three types of warnings are resolved.
> > First patch  : Block comments use * on subsequent lines
> > Second patch : Missing a blank line after declarations
> > third patch  : braces {} are not necessary for single statement blocks.
> >
> 
> Can we survive without this? Does it break build or alike?
> 
Yes. We can survive without this. It will not break build or alike. This changes will not affects the functionality of the code.
But, it overall improves the code readability.
> 
> > Dhaval Shah (3):
> >   platform/x86: dell-laptop: Block comments use * on subsequent lines
> >   platform/x86: dell-laptop: Missing a blank line after declarations
> >   platform/x86: dell-laptop: braces {} are not necessary for single
> >     statement blocks
> >
> >  drivers/platform/x86/dell-laptop.c | 10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > --
> > 2.11.0
> >



--
With Best Regards,
Andy Shevchenko