Re: [PATCH v5 5/7] scsi: libsas: use flush_workqueue to process disco events synchronously

[Hannes Reinecke]

On 12/08/2017 10:42 AM, Jason Yan wrote:
> Now we are processing sas event and discover event in different workqueues.
> It's safe to wait the discover event done in the sas event work. Use
> flush_workqueue() to insure the disco and revalidate events processed
> synchronously so that the whole discover and revalidate process will not
> be interrupted by other events.
> 
> Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
> CC: John Garry <john.garry@xxxxxxxxxx>
> CC: Johannes Thumshirn <jthumshirn@xxxxxxx>
> CC: Ewan Milne <emilne@xxxxxxxxxx>
> CC: Christoph Hellwig <hch@xxxxxx>
> CC: Tomas Henzl <thenzl@xxxxxxxxxx>
> CC: Dan Williams <dan.j.williams@xxxxxxxxx>
> ---
>  drivers/scsi/libsas/sas_port.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/scsi/libsas/sas_port.c b/drivers/scsi/libsas/sas_port.c
> index 9326628..64722f4 100644
> --- a/drivers/scsi/libsas/sas_port.c
> +++ b/drivers/scsi/libsas/sas_port.c
> @@ -192,6 +192,7 @@ static void sas_form_port(struct asd_sas_phy *phy)
>  		si->dft->lldd_port_formed(phy);
>  
>  	sas_discover_event(phy->port, DISCE_DISCOVER_DOMAIN);
> +	flush_workqueue(sas_ha->disco_q);
>  }
>  
>  /**
> @@ -277,6 +278,9 @@ void sas_porte_broadcast_rcvd(struct work_struct *work)
>  
>  	SAS_DPRINTK("broadcast received: %d\n", prim);
>  	sas_discover_event(phy->port, DISCE_REVALIDATE_DOMAIN);
> +
> +	if (phy->port)
> +		flush_workqueue(phy->port->ha->disco_q);
>  }
>  
>  void sas_porte_link_reset_err(struct work_struct *work)
> 
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@xxxxxxx			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 NÃrnberg
GF: F. ImendÃrffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG NÃrnberg)