Re: [PATCH] ip_gre: fix wrong return value of erspan_rcv

[William Tu]

On Thu, Dec 14, 2017 at 6:46 PM, Haishuang Yan
<yanhaishuang@xxxxxxxxxxxxxxxxxxxx> wrote:
> If pskb_may_pull return failed, return PACKET_REJECT instead of -ENOMEM.
>
> Fixes: 84e54fe0a5ea ("gre: introduce native tunnel support for ERSPAN")
> Cc: William Tu <u9012063@xxxxxxxxx>
> Signed-off-by: Haishuang Yan <yanhaishuang@xxxxxxxxxxxxxxxxxxxx>
> ---

Thanks for the patch.
I think the other way is simply to just 'goto drop', freeing the skb
in erspan_rcv(), instead of 'return PACKET_REJECT'. I'm ok either way.

Acked-by: William Tu <u9012063@xxxxxxxxx>