Re: [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h
From: Willem de Bruijn
Date: Fri Dec 15 2017 - 12:23:53 EST
On Fri, Dec 15, 2017 at 12:18 PM, Sven Eckelmann
<sven.eckelmann@xxxxxxxxxxxx> wrote:
> On Freitag, 15. Dezember 2017 11:57:55 CET Willem de Bruijn wrote:
>> > No, this is also bad because batman_adv.h is MIT license and packet.h is
>> > GPL-2. So what other name would you suggest for packet.h? batman_adv_packet.h?
>>
>> Sure, that sounds great. Thanks.
>
> Really? Isn't include/uapi/linux/batman_adv_packet.h looking like an accident
> which never should have had happened?
My only point was that renaming and modifying existing uapi files
can break userspace compilation.
As long as the existing files are not changed, I don't have a strong
opinion on naming for new files.