Re: [PATCH] efi: make EFI a menuconfig to ease disabling it all

From: Austin S. Hemmelgarn
Date: Fri Dec 15 2017 - 13:23:54 EST


On 2017-12-15 12:24, Vincent Legoll wrote:
Hello,

This looks fine to me. Ard?

Doesn't this break existing configs?

Would adding a "default yes" on the new menuconfig be OK.

If yes, I'd respin it for a v2

Alternatively, would it not make some degree of sense to just turn the CONFIG_EFI symbol into the menuconfig? It already controls all the EFI related stuff except GPT support (which should not be dependent on EFI support), so anyone who wants EFI support already has it enabled, and it would be a bit nicer to work with when actually configuring a kernel (It is rather annoying to have to effectively enable something twice).

The same (in theory) goes for pretty much any other patch like this where there's already a config option controlling it all that just isn't a menuconfig.