Re: [RESEND PATCH v2] dt: bindings: as3645a: Fix the example node

From: Rob Herring
Date: Fri Dec 15 2017 - 15:26:53 EST


On Fri, Dec 08, 2017 at 09:56:18AM -0600, Dan Murphy wrote:
> Resent to include DT maintainers
>
> On 12/08/2017 09:55 AM, Dan Murphy wrote:
> > Fix the address-cells and size-cells example node
> > to reflect to the correct representation.
> >
> > Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> > Acked-by: Pavel Machek <pavel@xxxxxx>
> > ---
> >
> > v2 - Moved compatible to be first in the node - https://patchwork.kernel.org/patch/10092937/
> >
> > Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> > index fdc40e354a64..fc7f5f9f234c 100644
> > --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> > +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> > @@ -59,10 +59,10 @@ Example
> > =======
> >
> > as3645a@30 {
>
> Rob
>
> Here is an example of the device name being part of the node name.
>
> Should this be changed as well to leds@30?

Yes, but I misspoke earlier and it should be "led-controller@30"

That can be a separate patch though, so for this one:

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>