Re: [PATCH] kernel/kprobes: kprobes_built_in can be boolean

From: Masami Hiramatsu
Date: Sat Dec 16 2017 - 09:50:34 EST


On Fri, 15 Dec 2017 14:41:12 +0800
guzhifeng <guzhifeng@xxxxxxxxxxxxxxxxxxxx> wrote:

> This patch makes kprobes_built_in return bool due to this
> particular function only using either one or zero as its return
> value.
>
> No functional change.

This seems OK to me.

Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

Thank you,

>
> Signed-off-by: guzhifeng <guzhifeng@xxxxxxxxxxxxxxxxxxxx>
> ---
> include/linux/kprobes.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h
> index 9440a2f..8d0d910 100644
> --- a/include/linux/kprobes.h
> +++ b/include/linux/kprobes.h
> @@ -219,9 +219,9 @@ struct kprobe_blacklist_entry {
> /*
> * For #ifdef avoidance:
> */
> -static inline int kprobes_built_in(void)
> +static inline bool kprobes_built_in(void)
> {
> - return 1;
> + return true;
> }
>
> #ifdef CONFIG_KRETPROBES
> @@ -409,9 +409,9 @@ static inline struct kprobe_ctlblk *get_kprobe_ctlblk(void)
>
> #else /* !CONFIG_KPROBES: */
>
> -static inline int kprobes_built_in(void)
> +static inline bool kprobes_built_in(void)
> {
> - return 0;
> + return false;
> }
> static inline int kprobe_fault_handler(struct pt_regs *regs, int trapnr)
> {
> --
> 1.8.3.1
>
>
>


--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>