Re: [PATCH v5 3/5] MIPS: Loongson64: Yeeloong add platform driver

[Philippe Ombredanne]

Dear Jiaxun,

On Sat, Dec 16, 2017 at 3:57 PM, Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> wrote:
> Yeeloong is a laptop with a MIPS Loongson 2F processor, AMD CS5536
> chipset, and KB3310B controller.

<snip>

> --- /dev/null
> +++ b/drivers/platform/mips/yeeloong_laptop.c
> @@ -0,0 +1,1142 @@
> +/*
> + * Driver for YeeLoong laptop extras
> + *
> + *  Copyright (C) 2017 Jiaxun Yang.
> + *  Author: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
> + *
> + *  Copyright (C) 2009 Lemote Inc.
> + *  Author: Wu Zhangjin <wuzhangjin@xxxxxxxxx>, Liu Junliang <liujl@xxxxxxxxxx>
> + *
> + *  Fixes: Petr Pisar <petr.pisar@xxxxxxxx>, 2012, 2013, 2014, 2015.
> + *
> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License version 2 as
> + *  published by the Free Software Foundation.
> + */

Would you mind using the new SPDX tags here. See Thomas patches [1]

> +MODULE_LICENSE("GPL");

Also please make sure your module license (here GPL 2.0 or later per
module.h) matches your top level license tag  correctly (here GPL 2.0
only)?

[1] https://lkml.org/lkml/2017/12/4/934

-- 
Cordially
Philippe Ombredanne