Re: tps65090-charger: Delete an error message for a failed memory allocation in two functions

From: Julia Lawall
Date: Sat Dec 16 2017 - 15:37:09 EST




On Sat, 16 Dec 2017, SF Markus Elfring wrote:

> >> Omit an extra message for a memory allocation failure in these functions.
> >
> > Because???
> >
> > Fix your commit message.
> >
> > Say _WHY_ should this be applied.
>
> I am still waiting for possibilities to improve also the corresponding
> reference documentation somehow as you know it already.

If you require someone else to update the documentation to be able to
explain why the patch is useful, then it would seem that you do not know
why the patch is useful, and thus should not submit it.

julia


>
> Regards,
> Markus
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>